Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removes SpeedreaderAndroidStudy to have Speedreader in default state #1175

Merged
merged 1 commit into from
Aug 12, 2024
Merged

Removes SpeedreaderAndroidStudy to have Speedreader in default state #1175

merged 1 commit into from
Aug 12, 2024

Conversation

SergeyZhukovsky
Copy link
Member

Resolves #1174

Test plan:

  • make sure that there is no SpeedreaderAndroidStudy

@SergeyZhukovsky SergeyZhukovsky self-assigned this Aug 9, 2024
@SergeyZhukovsky SergeyZhukovsky requested a review from a team as a code owner August 9, 2024 15:20
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 9, 2024 •
edited
Loading

✅ Test Seed Generated Successfully

To apply the test seed:

  1. Desktop: Launch the browser with --variations-pr=1175.
    Android: Set the command line to --variations-pr=1175 in debug menu, restart the browser.
    iOS: Set Variations PR to 1175 in Brave Core Switches debug menu, restart the browser.
  2. Wait 5-10 seconds to fetch the seed.
  3. Restart the browser to apply the seed.
  4. Ensure Active Variations section at brave://version starts with the expected seed version (see below).

Seed Details

Parameter Value
Version pull/1175@946040acc17dafb1ddfb1e22062634a812558784
Uploaded Fri, 09 Aug 2024 15:21:47 GMT
PR commit 5129544
Base commit 6a06002
Merge commit 946040a
Serial number 68345c0b61dbca78475a25e9dc12658e

@goodov goodov requested review from a team and removed request for a team August 9, 2024 17:44
kjozwiak
kjozwiak approved these changes Aug 12, 2024
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into production approved after deliberating with @brave/uplift-approvers.

@kjozwiak kjozwiak added this pull request to the merge queue Aug 12, 2024
Merged via the queue into main with commit a189a97 Aug 12, 2024
7 checks passed
@kjozwiak kjozwiak deleted the android_speedreader_remove branch August 12, 2024 18:10
@kjozwiak
Copy link
Member

Nightly verification(s):

Verification PASSED on Pixel 6 running Android 15 using the following build(s):

Brave | 1.70.66 Chromium: 128.0.6613.27 (Official Build) canary (64-bit)
--- | ---
Revision | 667a3d64bcaa33f50347e567971f37eeb76758aa
OS | Android 15; Build/AP31.240617.010; 35; REL
  • ensured that SpeedreaderAndroidStudy is not being displayed under brave://version
Example Example
Screenshot_20240812-143808 Screenshot_20240812-143757

BETA verification(s):

Verification PASSED on Pixel 6 running Android 15 using the following build(s):

Brave | 1.69.142 Chromium: 127.0.6533.100 (Official Build) beta (64-bit)
--- | ---
Revision | 49f7b324ba3979781c47181a213f4547fffd3c8d
OS | Android 15; Build/AP31.240617.010; 35; REL
  • ensured that SpeedreaderAndroidStudy is not being displayed under brave://version
Example Example
Screenshot_20240812-144959 Screenshot_20240812-145014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@SergeyZhukovsky SergeyZhukovsky

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove SpeedreaderAndroidStudy
2 participants
@SergeyZhukovsky @kjozwiak